🛡️ Sentinel: [CRITICAL] Fix SQL injection in metadata generator#192
🛡️ Sentinel: [CRITICAL] Fix SQL injection in metadata generator#192thebearwithabite wants to merge 1 commit intomasterfrom
Conversation
Co-authored-by: thebearwithabite <216692431+thebearwithabite@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
save_file_metadatamethod inmetadata_generator.pydynamically constructed SQLINSERT OR REPLACE INTOstatements using unvalidated dictionary keys (metadata.keys()) as column names. This exposed the application to SQL injection since column names cannot be parameterized.🎯 Impact: An attacker controlling the metadata keys could execute arbitrary SQL commands (e.g. drop tables, data exfiltration) or bypass intended access controls.
🔧 Fix: Fetched valid column names directly from the SQLite schema using
PRAGMA table_info(file_metadata)to create a strict allowlist. Filtered the incoming dictionary keys against this allowlist before dynamically constructing the SQL query string.✅ Verification: Ran
test_metadata.pyto ensure the metadata generator functions correctly with the applied column filtering.PR created automatically by Jules for task 5516510970673352591 started by @thebearwithabite